feat: cortex post-install script - init silently on install #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-jan
force-pushed
the
chore/postinstall-cortex-init-silently
branch
from
ab046bc to
d3e95ac
Compare
louis-jan
force-pushed
the
chore/postinstall-cortex-init-silently
branch
from
d3e95ac to
423e078
Compare
namchuai
approved these changes
Jun 2, 2024
|
LGTM. We might need to take care of the case user turn on/off AVX in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR adds a post-install script that downloads the corresponding Cortex dependencies based on the user's hardware specs during installation. So, after installing Cortex from the npm repo, there is no need to run
cortex initto get started.Removed cortex init step from README
Support:
Self Checklist